-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't control tick generation #79
Comments
Requirements:
|
The previous comment's 2nd point on having different scales for the value axis and tooltip should be broken down into two separate stories. In this story, we will focus on changes to the axes. A separate story can focus on changes to the tooltip. |
Analysis: Currently, Giraffe allows We will keep the above behavior and add two additional properties per axis that is mutually exclusively with the above. New: |
There is an existing bug that can be fixed with this issue. The bug is: when there are no y-axis ticks, the graph is wider because of the lack of margins. Margins were being calculated based on having y-axis ticks. Thus, no y-axis ticks means no margins. And when the graph is wider, the x-axis ticks get "erased" due to being overwritten by the redrawing of the wider graph. To fix this bug, we will use a sample y-axis tick based on the graph data to calculate the margins when the user specifically selects zero for the number of y-axis ticks. |
There is a second part to this story: Integrate this new feature into |
Upon further review, it is better to close this story out. As this story only deals with the Giraffe work, which has been completed, we will open a separate story to track the UI integration work. |
It's desirable to format ticks using a binary unit prefix when plotting data whose y-value is measured in bytes.
But the y-axis generates tick marks at "nice" intervals, i.e. at powers of 10. These intervals are no longer nice when formatting numbers with a binary unit prefix.
For example, here's the same plot with ticks formatted using a decimal unit prefix:
It has a nice tick of "6G". When formatting the ticks with a binary unit prefix, it looks like this:
The generated tick is now "5.5879G" (6 gigabytes =~ 5.88 gibibytes), which is no longer nice.
The text was updated successfully, but these errors were encountered: