refactor: Run cargo clippy on all rust files #4939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marwes
force-pushed
the
clippy2
branch
4 times, most recently
from
d027d74 to
0c67f92
Compare
|
Had to update rust as the |
|
ping @OfTheDelmer |
Marwes
force-pushed
the
clippy2
branch
3 times, most recently
from
5e91e84 to
de24ae3
Compare
skartikey
approved these changes
Aug 15, 2022
added 6 commits
August 16, 2022 13:28
We didn't run clippy on any tests and benchmarks before.
Fixes a bug with undocumented_unsafe_blocks in `#[test]` functions
Marwes
pushed a commit
that referenced
this pull request
Aug 17, 2022
Didn't think about us being locked to 1.58 when I created #4939 so I updated rust to fix the bug with the `undocumented_unsafe_blocks` lint. This downgrades rust again and adds an allow to work around it. cc #5084 (comment)
2 tasks
jsternberg
pushed a commit
that referenced
this pull request
Aug 17, 2022
* chore: Downgrade rust to 1.58 again Didn't think about us being locked to 1.58 when I created #4939 so I updated rust to fix the bug with the `undocumented_unsafe_blocks` lint. This downgrades rust again and adds an allow to work around it. cc #5084 (comment) * chore: make generate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't run clippy on any tests and benchmarks before.