fix(cmd): switch default port from 9999 to 8086 #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
reviewed
Feb 26, 2021
There was a problem hiding this comment.
This looks great! Have you signed the CLA? https://www.influxdata.com/legal/cla/
|
Thanks for the reminder @nathanielc ! |
|
@sunjincheng121 I just merged this change #3527 to disable a linter that was causing tests to fail in CI. If you rebase off master and allow CI to rerun, it should unblock you 🙌🏾 |
sunjincheng121
force-pushed
the
switch_port
branch
from
4c89b3f to
bba405d
Compare
|
Rebase the PR and trigger the CI. |
nathanielc
approved these changes
May 20, 2021
nathanielc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to switch the default port from 9999 to 8086, to align with InfluxDB[1].
What do you think?
[1] influxdata/influxdb#19494
Done checklist