Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Clockface 4): Progressbar #900

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

ChitlangeSahas
Copy link
Contributor

Closes #855

Changes

Screenshot 2022-11-08 at 12 19 28 PM

// Describe what you changed

Screenshots

// Add screenshots here if relevant

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@@ -25,7 +25,7 @@
.cf-progress-bar--text {
margin-top: $cf-space-2xs;
width: 100%;
color: $cf-grey-55;
color: #88889b;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will replace this in a future PR with a variable. That color is used as a hex in some more places.

@ChitlangeSahas ChitlangeSahas requested a review from a team November 8, 2022 19:25
@ChitlangeSahas ChitlangeSahas marked this pull request as ready for review November 8, 2022 19:25
@ChitlangeSahas ChitlangeSahas merged commit 782ca5a into clockface-4-master Nov 8, 2022
@ChitlangeSahas ChitlangeSahas deleted the clockface-4-progressbar branch November 8, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants