Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Clockface 4): Popovers #898

Merged
merged 1 commit into from
Nov 8, 2022
Merged

feat(Clockface 4): Popovers #898

merged 1 commit into from
Nov 8, 2022

Conversation

ChitlangeSahas
Copy link
Contributor

Closes #873

Screenshot 2022-11-08 at 10 55 39 AM

Screenshot 2022-11-08 at 10 55 27 AM

Screenshot 2022-11-08 at 10 55 21 AM

Changes

// Describe what you changed

Screenshots

// Add screenshots here if relevant

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@ChitlangeSahas ChitlangeSahas changed the base branch from master to clockface-4-master November 8, 2022 17:56
@ChitlangeSahas ChitlangeSahas requested a review from a team November 8, 2022 17:56
@ChitlangeSahas ChitlangeSahas merged commit 5561802 into clockface-4-master Nov 8, 2022
@ChitlangeSahas ChitlangeSahas deleted the clockface-4-popovers branch November 8, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCL735 TCL735 TCL735 approved these changes

@mavarius mavarius Awaiting requested review from mavarius mavarius is a code owner

@juliajames12 juliajames12 Awaiting requested review from juliajames12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clockface 4.0: Popover
2 participants
@ChitlangeSahas @TCL735