Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Clockface 4): Notifications #892

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

ChitlangeSahas
Copy link
Contributor

@ChitlangeSahas ChitlangeSahas commented Nov 4, 2022

Closes #832
Screenshot 2022-11-04 at 3 00 47 PM

Screenshot 2022-11-04 at 3 01 18 PM

Screenshot 2022-11-04 at 3 01 08 PM

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@ChitlangeSahas ChitlangeSahas requested a review from a team November 4, 2022 22:03
@@ -224,7 +223,6 @@ funnelPageExampleStories.add(
size={ComponentSize.Small}
visible={notificationState}
icon={IconFont.Zap}
gradient={Gradients.KawaiiDesu}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer use gradients.

@ChitlangeSahas ChitlangeSahas merged commit dfe6a24 into clockface-4-master Nov 4, 2022
@ChitlangeSahas ChitlangeSahas deleted the clockface-4-notification branch November 4, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants