chore(Clockface 4): remove unused color variables #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChitlangeSahas
requested review from
a team,
mavarius and
juliajames12
as code owners
|
|
TCL735
approved these changes
Nov 3, 2022
Yes! I'm thinking this is a good opportunity to replace all old colors, what happened with CF 3 is we only replaced surface level stuff, while keeping the old stuff. This made it so that there are a lot of places the old colors are still used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A chore to remove unused color variables. More cleanup coming in the future, we need to map the old colors to the new ones, this is the first step.