Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ButtonBase): clockface 4 colors #861

Merged
merged 5 commits into from
Oct 6, 2022
Merged

feat(ButtonBase): clockface 4 colors #861

merged 5 commits into from
Oct 6, 2022

Conversation

ChitlangeSahas
Copy link
Contributor

@ChitlangeSahas ChitlangeSahas commented Oct 6, 2022 •
edited
Loading

Closes #836

  1. Changes button colors.

Screen Shot 2022-10-06 at 12 18 13 AM

@ChitlangeSahas ChitlangeSahas marked this pull request as ready for review October 6, 2022 07:19
@ChitlangeSahas ChitlangeSahas requested a review from a team October 6, 2022 07:20
hoorayimhelping
hoorayimhelping reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we go forward, what is the overall plan for changing and adopting clockface 4.0? I noticed that the version isn't bumped in package.json - was this is a mistake or are you planning on collecting all the changes together and doing a single big release?

hoorayimhelping
hoorayimhelping approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we go forward, what is the overall plan for changing and adopting clockface 4.0?

Saw that this is actually merging into a branch, not master, so we're good to go for now.

@ChitlangeSahas ChitlangeSahas merged commit 1bb40f1 into clockface-4-master Oct 6, 2022
@ChitlangeSahas ChitlangeSahas deleted the clockface-4-button_updates branch October 6, 2022 16:30
@ChitlangeSahas
Copy link
Contributor Author

Part of #6090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

@mavarius mavarius Awaiting requested review from mavarius mavarius is a code owner

@juliajames12 juliajames12 Awaiting requested review from juliajames12

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChitlangeSahas @hoorayimhelping