Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Accordion, Alert, Button Color Updates #826

Open
wants to merge 2 commits into
base: feat/clockface-color-refactor-master
Choose a base branch
from

Conversation

brandenTenbrink
Copy link
Contributor

Closes #

Changes

Updated the colors to include the new Clockface Colors.

Updated the following components:

  • Accordion
  • Alert
  • Button

Screenshots

// Add screenshots here if relevant

Checklist

Check all that apply

  • Updated documentation to reflect changes
  • Added entry to top of Changelog with link to PR (not issue)
  • Tests pass
  • Peer reviewed and approved
  • Signed CLA (if not already signed)

@@ -20,6 +20,7 @@ const alertStories = storiesOf('Components/Alert', module).addDecorator(
withKnobs
)

// There is no css stylijng for these unused enums
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean Styling?

$c-magenta: #bf2fe5;
$c-deeppurple: #13002d;
$c-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an extra newline sneaked in here?

@@ -249,7 +273,7 @@ export enum InfluxColors {
Topaz = '#E85B1C',
Tiger = '#F48D38',
Pineapple = '#FFB94A',
Thunder = '#FFD255',
//Thunder = '#FFD255',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're trying to delete this color we should remove it instead of commenting it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants