Conversation
bednar
requested changes
Jan 19, 2026
Contributor
bednar
left a comment
There was a problem hiding this comment.
@vlastahajek thanks for this improvement! 👍
Please add tests for previously failed InfluxQL from https://influxdata.slack.com/archives/C5BSZ026L/p1767895523973259
70b2b71 to
b9dc3c0
Compare
Contributor
|
Basic tests completed following recommendations in description. Completed plan can be found here. Looks good to me. 🚴 🏁 |
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current InfluxQL parser, taken from InfluxDB 1.1.5 doesn't support sub-queries. A parser is needed for V3 support to adjust queries for the backward compatibility endpoint.
Major changes:
Testing requirements:
verify the new binaries correctly work on target platforms
verify InfluxQL editor works correctly
verify Flux editor works correctly
verify Kapacitor management, especially using Teams channel URL
CHANGELOG.md updated with a link to the PR (not the Issue)
Well-formatted commit messages
Rebased/mergeable
Tests pass
swagger.json updated (if modified Go structs or API)