Skip to content

Conversation

@wiedld
Copy link

@wiedld wiedld commented Dec 13, 2024

Refer to this PR for the list of patches:
#48

How the different "oct-30" upgrades are related:

  1. We were on commit 922b399 with the original Oct-30 upgrade in iox.
    • this included the revert of the stringview enablement

.

  1. we then "advanced" by a single commit, by pointing iox to the commit before the stringview revert. 50e1209
Screenshot 2024-12-17 at 6 14 03 PM

.

  1. now we have a new branch, that adds back the single commit for SPM round robin.
Screenshot 2024-12-17 at 6 19 49 PM

…ache#13133)

* first draft

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* add data

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* fix benchmark

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* add more bencmark data

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* fix benchmark

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* fmt

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* get max size

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* add license

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* rm code for merge

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* cleanup

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* cleanup

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* update poll count only we have tie

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* upd comment

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* fix logic

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* configurable

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* fmt

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* add mem limit test

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* rm test

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* escape bracket

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* add test

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* rm per consumer record

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* repartition limit

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* add benchmark

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* cleanup

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* benchmark with parameter

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* only calculate consumer pool if the limit is set

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* combine eq and gt

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* review part 1

* Update merge.rs

* upd doc

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* no need index comparison

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* combine handle tie and eq check

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* upd doc

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* fmt

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* add more comment

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* remove flag

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* upd comment

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* Revert "remove flag"

This reverts commit 8d6c0a6.

* Revert "upd comment"

This reverts commit a18cba8.

* add more comment

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* add more comment

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* fmt

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* simpliy mem pool

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* clippy

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

* Update merge.rs

* minor

* add comment

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>

---------

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Co-authored-by: berkaysynnada <berkay.sahin@synnada.ai>
@wiedld wiedld force-pushed the dlw/oct-30-with-spm-change branch from 0ee794c to ae0a57b Compare December 18, 2024 02:08
@wiedld wiedld changed the base branch from iox-12627/patched-DF-oct-30 to df-upgrade-base-oct-30 December 18, 2024 02:10
@alamb
Copy link
Collaborator

alamb commented Dec 18, 2024

❤️

@wiedld
Copy link
Author

wiedld commented Jan 7, 2025

We have moved past this version. Closing.

@wiedld wiedld closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants