Skip to content

WIP(iox-10891): patched df upgrade 202-05-31 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

WIP(iox-10891): patched df upgrade 202-05-31 #24

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b93d3ac
chore: fix `first_value` and `last_value` coercion
appletreeisyellow Jun 5, 2024
8ef9788
Merge commit '3d007608535cb138ae4473ce6305bd4ec8481627' into chunchun…
appletreeisyellow Jun 5, 2024
c7cb88b
Merge commit '7638a26979382f98fe9725a75424acf0788ff26a' into chunchun…
appletreeisyellow Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions datafusion/functions-aggregate/src/first_last.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ use datafusion_common::{
arrow_datafusion_err, internal_err, DataFusionError, Result, ScalarValue,
};
use datafusion_expr::function::{AccumulatorArgs, StateFieldsArgs};
use datafusion_expr::type_coercion::aggregates::NUMERICS;
use datafusion_expr::utils::{format_state_name, AggregateOrderSensitivity};
use datafusion_expr::{
Accumulator, AggregateUDFImpl, ArrayFunctionSignature, Signature, TypeSignature,
Expand Down Expand Up @@ -75,7 +74,8 @@ impl FirstValue {
vec![
// TODO: we can introduce more strict signature that only numeric of array types are allowed
TypeSignature::ArraySignature(ArrayFunctionSignature::Array),
TypeSignature::Uniform(1, NUMERICS.to_vec()),
TypeSignature::Numeric(1),
TypeSignature::Uniform(1, vec![DataType::Utf8]),
],
Volatility::Immutable,
),
Expand Down Expand Up @@ -373,7 +373,8 @@ impl LastValue {
vec![
// TODO: we can introduce more strict signature that only numeric of array types are allowed
TypeSignature::ArraySignature(ArrayFunctionSignature::Array),
TypeSignature::Uniform(1, NUMERICS.to_vec()),
TypeSignature::Numeric(1),
TypeSignature::Uniform(1, vec![DataType::Utf8]),
],
Volatility::Immutable,
),
Expand Down