Update how Dataset gets set for the Sequel gem #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unsure if this gem is being actively maintained or not, but our organization is testing it out to help handle migrations for a new Redshift project we're working on so we don't have to handle it internally. We ran into this and figured we ought PR it in case anyone else is having issues!
Apparently how the Dataset is injected/set changed. This PR appears to correct the issue no problem, though I don't know that I'm familiar enough with the inner workings of the spec suite / Sequel gem to write an appropriate spec for this.
cc @adomokos