This repository was archived by the owner on Aug 17, 2021. It is now read-only.
Routing #16
Open
Routing #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkoKukovec
reviewed
Sep 6, 2019
| import { Navbar } from './Navbar'; | ||
|
|
||
| it('renders without crashing', () => { | ||
| const div = document.createElement('div'); |
There was a problem hiding this comment.
Wouldn't something like const footer = create(<Footer />); also work instead of rendering into the DOM?
| margin-bottom: 100px; | ||
| `; | ||
|
|
||
| const navigationLink = css` |
There was a problem hiding this comment.
The class variables should be named consistently, so better to add the Class suffix here also
|
|
||
| const About: React.FC<{}> = () => { | ||
| const [title, setTitle] = React.useState(''); | ||
| const [content, setContent] = React.useState(''); |
There was a problem hiding this comment.
You should also handle the loading and error states. That's quite simple with the useAsync hook from react-use
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navbarcomponent & related basic testAboutcontainer component & related testHomecontainer component & related testreact-routerexample with lazy loading routeuseEffecthook and API call with local state update