Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:rage3: windows working and fight node modules #179

Merged
merged 2 commits into from
Feb 27, 2018
Merged

:rage3: windows working and fight node modules #179

merged 2 commits into from
Feb 27, 2018

Conversation

GantMan
Copy link
Member

@GantMan GantMan commented Feb 27, 2018

Node will inject its own bin to the front of $PATH, as identified in #175

This simply moves that injection to the back to prefer global over anything node_modules/.

Tests included. I attempted to go a wrong way first, and that left strange artifacts I had to clean up. Squash to kill the noise


Closes: #175

@codecov
Copy link

codecov bot commented Feb 27, 2018

Codecov Report

Merging #179 into master will decrease coverage by 0.39%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #179     +/-   ##
=========================================
- Coverage   82.87%   82.47%   -0.4%     
=========================================
  Files          32       33      +1     
  Lines         613      622      +9     
  Branches      103      107      +4     
=========================================
+ Hits          508      513      +5     
- Misses         69       70      +1     
- Partials       36       39      +3
Impacted Files Coverage Δ
src/extensions/functions/checkCLI.ts 92.85% <100%> (+8.24%) ⬆️
src/extensions/functions/checkCLIForUpdates.ts 85.71% <50%> (-6.6%) ⬇️
src/extensions/functions/updateRequirement.ts 88.37% <50%> (-2.11%) ⬇️
src/extensions/functions/quirksNodeModules.ts 66.66% <66.66%> (ø)
src/extensions/functions/solidarityReport.ts 88.88% <0%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c7652...9b262a7. Read the comment docs.

@GantMan GantMan mentioned this pull request Feb 27, 2018
@GantMan GantMan merged commit 3b0cede into master Feb 27, 2018
@GantMan GantMan deleted the windows-working branch February 27, 2018 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant