Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support json5 #165

Merged
merged 3 commits into from
Jan 22, 2018
Merged

Support json5 #165

merged 3 commits into from
Jan 22, 2018

Conversation

GantMan
Copy link
Member

@GantMan GantMan commented Jan 22, 2018

Adds JSON5 to the parsing of solidarity files.


Closes #155

@avaGitHubBot
Copy link

avaGitHubBot commented Jan 22, 2018

Warnings
⚠️

Changes were made to package.json, but not to yarn.lock - Perhaps you need to run yarn install?

⚠️

Changes were made to package.json, but not to package-lock.json - Perhaps you need to run npm install?

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Jan 22, 2018

Codecov Report

Merging #165 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   81.43%   81.43%           
=======================================
  Files          28       28           
  Lines         528      528           
  Branches       82       82           
=======================================
  Hits          430      430           
  Misses         66       66           
  Partials       32       32
Impacted Files Coverage Δ
src/extensions/functions/getSolidaritySettings.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b940f0a...830779f. Read the comment docs.

@GantMan
Copy link
Member Author

GantMan commented Jan 22, 2018

Thanks @avaGitHubBot - but I simply moved from devDep to dep.

@GantMan GantMan merged commit cecd47e into master Jan 22, 2018
@GantMan GantMan deleted the support_json5 branch January 22, 2018 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants