Spellcheck - Via Function #157

GantMan · 2018-01-02T16:59:30Z

Creating a PR for testing function-powered spellcheck exceptions.

TravisBuddy · 2018-01-02T17:01:33Z

Travis tests have failed

Hey Gant Laborde,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci

> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts
PASS __tests__/command_helpers/checkCLIForUpdates.ts
PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/command_helpers/checkDir.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts
PASS __tests__/commands/report.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/schema/validateExampleSchema.ts

Test Suites: 28 passed, 28 total
Tests:       126 passed, 126 total
Snapshots:   27 passed, 27 total
Time:        10.014s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/madge --extensions ts --circular src/
⠋ commands/report.ts⠙ commands/snapshot.ts⠹ commands/solidarity.ts⠸ extensions/functions/binaryExists.ts⠼ extensions/functions/checkCLI.ts⠴ extensions/functions/checkCLIForUpdates.ts⠦ extensions/functions/checkDir.ts⠧ extensions/functions/checkENV.ts⠇ extensions/functions/checkFile.ts⠏ extensions/functions/checkRequirement.ts⠋ extensions/functions/checkShell.ts⠙ extensions/functions/getLineWithVersion.ts⠹ extensions/functions/getSolidaritySettings.ts⠸ extensions/functions/getVersion.ts⠼ extensions/functions/printResults.ts⠴ extensions/functions/removeNonVersionCharacters.ts⠦ extensions/functions/reviewRule.ts⠧ extensions/functions/setSolidaritySettings.ts⠇ extensions/functions/updateRequirement.ts⠏ extensions/functions/updateVersions.ts⠋ ./index.tsProcessed 28 files (732ms) (2 warnings)

✔ No circular dependency found!

Done in 4.51s.

yarn danger

yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger
stderr: Unable to evaluate the Dangerfile

child process exited with code 0
Failing the build, there is 1 fail.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Node.js: 8

npm run test:ci

> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts
PASS __tests__/command_helpers/checkCLIForUpdates.ts
PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/command_helpers/checkDir.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts
PASS __tests__/commands/report.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/schema/validateExampleSchema.ts

Test Suites: 28 passed, 28 total
Tests:       126 passed, 126 total
Snapshots:   27 passed, 27 total
Time:        13.602s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/madge --extensions ts --circular src/
⠋ commands/report.ts⠙ commands/snapshot.ts⠹ commands/solidarity.ts⠸ extensions/functions/binaryExists.ts⠼ extensions/functions/checkCLI.ts⠴ extensions/functions/checkCLIForUpdates.ts⠦ extensions/functions/checkDir.ts⠧ extensions/functions/checkENV.ts⠇ extensions/functions/checkFile.ts⠏ extensions/functions/checkRequirement.ts⠋ extensions/functions/checkShell.ts⠙ extensions/functions/getLineWithVersion.ts⠹ extensions/functions/getSolidaritySettings.ts⠸ extensions/functions/getVersion.ts⠼ extensions/functions/printResults.ts⠴ extensions/functions/removeNonVersionCharacters.ts⠦ extensions/functions/reviewRule.ts⠧ extensions/functions/setSolidaritySettings.ts⠇ extensions/functions/updateRequirement.ts⠏ extensions/functions/updateVersions.ts⠋ ./index.tsProcessed 28 files (746ms) (2 warnings)

✔ No circular dependency found!

Done in 4.52s.

yarn danger

yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger
stderr: Unable to evaluate the Dangerfile

child process exited with code 0
Failing the build, there is 1 fail.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

codecov · 2018-01-02T18:41:40Z

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files          28       28           
  Lines         534      534           
  Branches       83       83           
=======================================
  Hits          436      436           
  Misses         66       66           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc87c77...3fc43ec. Read the comment docs.

TravisBuddy · 2018-01-02T21:18:22Z

Travis tests have failed

Hey Gant,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci

> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts
PASS __tests__/command_helpers/checkCLIForUpdates.ts
PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/command_helpers/checkDir.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts
PASS __tests__/commands/report.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/schema/validateExampleSchema.ts

Test Suites: 28 passed, 28 total
Tests:       126 passed, 126 total
Snapshots:   27 passed, 27 total
Time:        10.265s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/madge --extensions ts --circular src/
⠋ commands/report.ts⠙ commands/snapshot.ts⠹ commands/solidarity.ts⠸ extensions/functions/binaryExists.ts⠼ extensions/functions/checkCLI.ts⠴ extensions/functions/checkCLIForUpdates.ts⠦ extensions/functions/checkDir.ts⠧ extensions/functions/checkENV.ts⠇ extensions/functions/checkFile.ts⠏ extensions/functions/checkRequirement.ts⠋ extensions/functions/checkShell.ts⠙ extensions/functions/getLineWithVersion.ts⠹ extensions/functions/getSolidaritySettings.ts⠸ extensions/functions/getVersion.ts⠼ extensions/functions/printResults.ts⠴ extensions/functions/removeNonVersionCharacters.ts⠦ extensions/functions/reviewRule.ts⠧ extensions/functions/setSolidaritySettings.ts⠇ extensions/functions/updateRequirement.ts⠏ extensions/functions/updateVersions.ts⠋ ./index.tsProcessed 28 files (741ms) (2 warnings)

✔ No circular dependency found!

Done in 4.62s.

yarn danger

yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger
stderr: Unable to evaluate the Dangerfile

child process exited with code 0
Failing the build, there is 1 fail.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Node.js: 8

npm run test:ci

> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts
PASS __tests__/command_helpers/checkCLIForUpdates.ts
PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/command_helpers/checkDir.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts
PASS __tests__/commands/report.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/schema/validateExampleSchema.ts

Test Suites: 28 passed, 28 total
Tests:       126 passed, 126 total
Snapshots:   27 passed, 27 total
Time:        13.496s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/madge --extensions ts --circular src/
⠋ commands/report.ts⠙ commands/snapshot.ts⠹ commands/solidarity.ts⠸ extensions/functions/binaryExists.ts⠼ extensions/functions/checkCLI.ts⠴ extensions/functions/checkCLIForUpdates.ts⠦ extensions/functions/checkDir.ts⠧ extensions/functions/checkENV.ts⠇ extensions/functions/checkFile.ts⠏ extensions/functions/checkRequirement.ts⠋ extensions/functions/checkShell.ts⠙ extensions/functions/getLineWithVersion.ts⠹ extensions/functions/getSolidaritySettings.ts⠸ extensions/functions/getVersion.ts⠼ extensions/functions/printResults.ts⠴ extensions/functions/removeNonVersionCharacters.ts⠦ extensions/functions/reviewRule.ts⠧ extensions/functions/setSolidaritySettings.ts⠇ extensions/functions/updateRequirement.ts⠏ extensions/functions/updateVersions.ts⠋ ./index.tsProcessed 28 files (778ms) (2 warnings)

✔ No circular dependency found!

Done in 5.41s.

yarn danger

yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger
stderr: Unable to evaluate the Dangerfile

child process exited with code 0
Failing the build, there is 1 fail.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Testing dynamic addition

763e159

GantMan added the enhancement label Jan 2, 2018

spell check latest plugin

adc34b0

is this a fix?

2a53e94

GantMan added 15 commits January 2, 2018 15:57

use cSpell for exceptions

aaef54b

false set off spellcheck

430e61d

updating spell words

434d672

remove intentional typo

46df429

add typo again for SCIENCE

9531af1

latest spellcheck

522df54

readme is good now

58da78b

moved to danger 3.x

1df693e

testing md typo

4ef8d05

fixings

3cf9dc8

spelling fixups

d104865

small updates

2a81ce8

enforce file skip attempt

3e45cfa

confused

4c19ad6

fix spell checker

3fc43ec

GantMan merged commit 5b65d00 into master Jan 4, 2018

GantMan deleted the update_spellcheck branch January 4, 2018 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spellcheck - Via Function #157

Spellcheck - Via Function #157

GantMan commented Jan 2, 2018

TravisBuddy commented Jan 2, 2018

codecov bot commented Jan 2, 2018 •

edited

Loading

TravisBuddy commented Jan 2, 2018

Spellcheck - Via Function #157

Spellcheck - Via Function #157

Conversation

GantMan commented Jan 2, 2018

TravisBuddy commented Jan 2, 2018

Travis tests have failed

Node.js: node

Node.js: 8

codecov bot commented Jan 2, 2018 • edited Loading

Codecov Report

TravisBuddy commented Jan 2, 2018

Travis tests have failed

Node.js: node

Node.js: 8

codecov bot commented Jan 2, 2018 •

edited

Loading