fix(ui): handle unexpected timeline payloads - #1618
Open
giaBaoJS wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn build-and-test:localpassesREADME.md(or relevant documentation) has been updated with your changes (not applicable: no public API or setup changed)Describe your PR
Fixes #1600.
Timeline commands can now be produced by the MCP server as well as the client SDK, so their runtime payloads are not always as complete as their TypeScript contracts. This keeps each affected command visible in the timeline instead of dropping into the generic
RENDER ERRORentry when optional data is missing or has the wrong container shape.datais an object with akeystepsbefore reading the final entrychildrenbefore reading/mapping it0 EffectsValid payload rendering remains unchanged. The API toolbar receives the normalized request and response too, so its callbacks do not reintroduce the same unsafe nested access after the row opens.
Test plan
reactotron-core-ui: 10 suites, 99 tests passed.yarn build-and-test:local: passed build, package validation, lint, format, all workspace tests, and typecheck for all 13 projects.timelineCommandResolver; every record kept its command title, none renderedRENDER ERROR, and the valid previews remained intact.