Conversation
🦋 Changeset detectedLatest commit: c335f27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey @dccarmo - sorry for the long delay here. @frankcalise and I are going to review this sometime soon and get back to you. Appreciate the work! |
frankcalise
left a comment
frankcalise
left a comment
There was a problem hiding this comment.
Hey thanks for the submission, couple of things to take a look at here if you don't mind.
|
|
||
| struct TextRecord: Record { | ||
| @Field var text: String = "" | ||
| @Field var textBlocks: [TextBlockRecord] = [] |
There was a problem hiding this comment.
I think we can rename this to blocks to match the API docs more closely.
| @Field var textBlocks: [TextBlockRecord] = [] | |
| @Field var blocks: [BlockRecord] = [] |
| struct TextBlockRecord: Record { | ||
| @Field var text: String = "" | ||
| @Field var frame: RectRecord = RectRecord() | ||
| @Field var recognizedLanguage: String = "" |
There was a problem hiding this comment.
What was the decision here to only return the first language code over retrieving the array as the data structure is documented?
| { | ||
| "permissions": { | ||
| "allow": [ | ||
| "WebFetch(domain:developers.google.com)" | ||
| ], | ||
| "deny": [], | ||
| "ask": [] | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
issue: please remove this claude config - I don't want other people to get the same permissions you granted on your machine.
| [], | ||
| ) | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Working on iOS when selecting images:
|
Hey @dccarmo - I rebased your PR against |
|
Hey @coolsoftwaretyler, sorry for the late reply. I've been busy with two separate projects and while I appreciate the reviews from you and @frankcalise, unfortunately I don't have the time to fix them right now. Feel free to takeover and work on the required updates to release this to the public. Thanks so much! |
|
Thanks @dccarmo! We will take it from here. |
|
Closing in favor of #235 |
3 participants
Description
Closes #210
This PR adds initial support for MLKit Text Recognition v2 for both iOS and Android.
Please let me know if I missed any collaboration steps or if there's anything else that needs to be updated.
Future work