fix: update worklets exclude to drop version #3001
Open
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's an issue when providing the version in the
expo.install.excludes
keys, which might be related to the -nightly suffix as it doesn't fall into some of the prerelease tags (not 100% on this).Looking at the docs, it seems like they may have migrated away from providing the specific version in the key anyway? This doesn't match with Expo's test cases on the matter, but it is what the docs say now.
In addition to this, I updated the
expo-router
version we slide into the template from the new command. This wasn't required, asexpo install --fix
actually would have fixed it anyway, should the worklets install would have actually been excluded.Screenshots
Before terminal output
Note how it says it is skipping them, but it still lists it as a version it is going to update with
install --check
After terminal output
Then, when dropping the version from package.json: