Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boilerplate): added node version check #2449

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Conversation

frankcalise
Copy link
Contributor

@frankcalise frankcalise commented May 25, 2023

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant

Describe your PR

When you are below the required version, yarn will stop at this check:

[1/5] 🔍  Validating package.json...
error hello-world@0.0.1: The engine "node" is incompatible with this module. Expected version ">=18". Got "16.14.2"

@frankcalise frankcalise marked this pull request as ready for review May 25, 2023 15:08
Copy link
Contributor

@joshuayoes joshuayoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to consider adding this to the parent package.json to have users get an error for using the ignite-cli with an older version of Node as well

@frankcalise
Copy link
Contributor Author

@joshuayoes We do have devEngines in the root package.json, however I can't find any documentation on that, I'm guessing they changed the key to engines. Should be safe to just rename this and update versions you think?

  "devEngines": {
    "node": ">=7.x",
    "npm": ">=4.x"
  },

@joshuayoes
Copy link
Contributor

engines is the only official npm key: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#engines

It looks like devEngines may be in reference to an old fbjs library? npm/npm#9765 I'd say it's safe to remove at this point

@jamonholmgren
Copy link
Member

Looks like we need to bump the circleci node version.

@joshuayoes
Copy link
Contributor

Seems the tests failing is related to this: facebook/react-native#36440

@frankcalise frankcalise merged commit ef14473 into master Jun 29, 2023
@frankcalise frankcalise deleted the fix/node-engine-ver branch June 29, 2023 15:25
infinitered-circleci pushed a commit that referenced this pull request Jun 29, 2023
## [8.8.3](v8.8.2...v8.8.3) (2023-06-29)

### Bug Fixes

* **boilerplate:** added node version check ([#2449](#2449) by [@frankcalise](https://github.com/frankcalise)) ([ef14473](ef14473))
@infinitered-circleci
Copy link

🎉 This PR is included in version 8.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Node version check
4 participants