-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(boilerplate): added node version check #2449
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to consider adding this to the parent package.json
to have users get an error for using the ignite-cli
with an older version of Node as well
@joshuayoes We do have
|
It looks like |
Looks like we need to bump the circleci node version. |
Seems the tests failing is related to this: facebook/react-native#36440 |
## [8.8.3](v8.8.2...v8.8.3) (2023-06-29) ### Bug Fixes * **boilerplate:** added node version check ([#2449](#2449) by [@frankcalise](https://github.com/frankcalise)) ([ef14473](ef14473))
🎉 This PR is included in version 8.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Please verify the following:
yarn test
jest tests pass with new tests, if relevantDescribe your PR
package.json
so @jamonholmgren keeps me aroundWhen you are below the required version,
yarn
will stop at this check: