Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first landing page image and animations #50

Merged
merged 6 commits into from
Jan 12, 2023
Merged

Conversation

cdanwards
Copy link
Member

@cdanwards cdanwards commented Jan 11, 2023

This PR adds the first of the feature images on the landing page with it's animation. The animations should only occur the initial time that the image container comes into view.

Screen.Recording.2023-01-11.at.3.03.59.PM.mov
Screen.Recording.2023-01-11.at.3.04.55.PM.mov

@cdanwards cdanwards marked this pull request as ready for review January 11, 2023 20:07
Copy link
Contributor

@kateinkim kateinkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing!!!!

just a nit : I wonder if it will look better if we could add a bit of spacing between the description and the animation image in mobile view.

@cdanwards cdanwards merged commit 79816a8 into main Jan 12, 2023
@cdanwards cdanwards deleted the feat/first-image branch January 12, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants