Get Algolia working #144
Merged
Get Algolia working #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Minimal Algolia config, which also gives us automatic nesting of search result headers under their parent pages Notes on styles: - Pre-existing styling logic doesn't apply cleanly to the new search component, and I got tired of trying to figure out Infima's intended usage (it's not very well-documented). - Instead, I just updated the search box background to our background color instead of the cool gray it was, and decreased the default border radius, since the oval shape wasn't matched anywhere else. Would be nice for the future: - De-prioritize results from "Archive" - More intentionally style the search component
|
FYI @cdanwards I ended up removing a bunch of existing styles and mostly going with the default, but please suggest improvements if you'd like |
lindboe
requested review from
cdanwards,
markrickert,
morganick,
frankcalise and
Jpoliachik
cdanwards
approved these changes
Mar 12, 2024
frankcalise
approved these changes
Mar 12, 2024
|
@cdanwards I didn't have any ideas in particular, just wanted to make sure nothing important was removed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #58.
Minimal Algolia config, which also gives us automatic nesting of search result headers under their parent pages.
Notes on styles:
Would be nice for the future: