Skip to content

Conversation

@Leischii
Copy link

@Leischii Leischii commented Mar 23, 2025

This started with me just wanting to expand the bgm for personal use but thought I could share it in case anyone wants to use it/pick it up. If anyone wants to finish this credits would be nice.

Changes:

  • Added low health bgm audio from black and white
  • Added logic to switch from current battle bgm to low health bgm when own pokemon is at or below 25% health
  • Changed pbStringToAudioFile logic to split string at ":" instead of using 2 regex for most audio load. Should be a lot better for performance and also seems to reduce loading times.
  • Added missing attr_accessor for bgs_position

Todos:

  • Modify mp3 to loop better. Just picked a file I found for now
  • Make sure bgm always changes according to own Pokemons health. I think I caught all instances, but due to being new to the project and ruby in general I'm not 100% sure
  • Make sure spliting the string at ":" is actually better for performance and has no drawbacks. Couldn't find any instances of the ###:###:### format so I couldn't confirm it.

@Leischii
Copy link
Author

Update on this: I will finish this PR and expand it to be smth you could almost call a full on battle bgm overhaul.

Right now i am planing to:

  • Improve current PR (I understand ruby a bit better now, so there is a lot I can improve already)
  • Add logic for a new game setting called "music style" which allows you to choose between the current bgm implemention or a new one which makes it so everytime you enter a wild, trainer, rival, gym or elite4 battle, you will get a matching track from a random pokemon generation
  • Add bgm and logic for last gym leader pokemon (matching the pokemon generation of the bgm playing at the time)
  • Add correct bgm looping for all these tracks
  • (Maybe) Add more audio effects (e.g. add the sound for the animation when the amount of pokemon each side has is shown via Pokeballs at the start of a trainer battle)

No eta as I'm still working on looping all audios and I have no idea how long this will take or if the scope might change again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant