IPROTO-341 Transcode json array root object

[fax4ever]

https://issues.redhat.com/browse/IPROTO-341

[tristantarrant]

I tried running Infinispan's server/rest testsuite with a protostream snapshot compiled with this PR and I get the following failure:

SearchCountClusteredTest>MultipleCacheManagersTest.createBeforeClass:118->MultipleCacheManagersTest.callCreateCacheManagers:124->MultiNodeRestTest.createCacheManagers:51->MultiNodeRestTest.registerProtobuf:72 » MalformedJson Invalid JSON at [1,2]

[fax4ever]

I tried running Infinispan's server/rest testsuite with a protostream snapshot compiled with this PR and I get the following failure:

SearchCountClusteredTest>MultipleCacheManagersTest.createBeforeClass:118->MultipleCacheManagersTest.callCreateCacheManagers:124->MultiNodeRestTest.createCacheManagers:51->MultiNodeRestTest.registerProtobuf:72 » MalformedJson Invalid JSON at [1,2]

Thank you @tristantarrant for checking it.
I did the same, basically running the snapshot with the Infinispan CI, but I didn't run the server tests module.
I'm checking it!

[fax4ever]

@tristantarrant It seems that I have the same issue also if I run the server/test tests from the current main:

[ERROR] Errors: 
[ERROR]   EmbeddedRestSearchTest>MultipleCacheManagersTest.createBeforeClass:118->MultipleCacheManagersTest.callCreateCacheManagers:124->BaseRestSearchTest.createCacheManagers:111->BaseRestSearchTest.registerProtobuf:544 » MalformedJson Invalid JSON at [1,2]
[ERROR]   NonIndexedRestSearchTest>MultipleCacheManagersTest.createBeforeClass:118->MultipleCacheManagersTest.callCreateCacheManagers:124->BaseRestSearchTest.createCacheManagers:111->BaseRestSearchTest.registerProtobuf:544 » MalformedJson Invalid JSON at [1,2]
[INFO] 
[ERROR] Tests run: 2221, Failures: 0, Errors: 2, Skipped: 22
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:52 min
[INFO] Finished at: 2024-06-26T10:18:15+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.2.5:test (defau

I'm not sure this is related to this contribution. There are probably some interleaving-cases that cause this error. Considering for instance that usually the JSON serializzation context is not thread safe, making it visible only on local runs but not on CI.

[ryanemerson]

@fax4ever Do these failures occur every time on main? If so, I wonder why they're not being picked up by CI.

[fax4ever]

@fax4ever Do these failures occur every time on main? If so, I wonder why they're not being picked up by CI.

Good question. Just re-running the server rest tests on the current main and on this branch, I haven't seen the failures. :(

So at this point I would say that maybe that EmbeddedRestSearchTest and NonIndexedRestSearchTest are flaky tests...

Probably the test results depend on the particular interleaving on which the tests are concurrently executed, since the exception is the classic exception when we try to access to JSON serialization context concurrently.

[tristantarrant]

The Infinispan testsuite passed for me. Merging

[fax4ever]

Thanks @tristantarrant