Align Infinispan version to the one in Swarm #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also, it shouldn't depend on the huge infinispan-embedded module which is a big dependency. It should depend only what it really needs.
Contributor
Author
|
The current set up where it depends on Infinispan 9 does not work. At runtime it really uses 8.2.4, the one provided by Swarm. To make it use Infinispan 9, we'd need to create a fraction that uses Infinispan 9 (as indicated by Ken) |
Collaborator
|
So this PR doesn't apply and we can close it? |
Contributor
Author
|
Of course it applies. It's misleading to have the project depend on Infinispan 9 when at runtime it really uses Infinispan 8. |
Contributor
Author
|
On top of that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is a big dependency. It should depend only what it really needs.