Skip to content

fix: disable default proxy when proxy is not enabled #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2025
Merged

fix: disable default proxy when proxy is not enabled #91

merged 2 commits into from
Feb 24, 2025

Conversation

@medcl
Copy link
Member

@medcl medcl commented Feb 24, 2025 •
edited
Loading

What does this PR do

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@medcl medcl changed the title fix: don't enable default proxy by default if proxy is not eabled fix: disable default proxy when proxy is not enabled Feb 24, 2025
luohoufu
luohoufu approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@luohoufu luohoufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@medcl medcl merged commit f5fdde4 into main Feb 24, 2025
5 checks passed
@medcl medcl deleted the default_proxy branch February 24, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silenceqi silenceqi silenceqi approved these changes

@luohoufu luohoufu luohoufu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@medcl @silenceqi @luohoufu