fix: comsumer segment without producer #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This pull request includes several changes to improve error handling and add new checks in the disk queue consumer module. The most important changes include fixing a bug related to the consumer segment, adding checks for the reader and empty queues, and enhancing error logging.
Bug Fixes and Improvements:
docs/content.en/docs/release-notes/_index.md: Fixed consumer segment without producer issue.Error Handling Enhancements:
modules/queue/disk_queue/consumer.go: Added a check to ensure the reader is not nil before reading the message size.modules/queue/disk_queue/consumer.go: Improved error logging for decompression errors by including additional context.modules/queue/disk_queue/consumer.go: Added a check to handle cases where no producer has written data to the queue.Additional Checks:
modules/queue/disk_queue/module.go: Added a check to prevent creating a consumer for an empty queue.plugins/queue/consumer/consumer.go: Modified error handling to exclude "empty queue" errors from being logged as worker errors.Rationale for this change
Standards checklist