Skip to content

fix: rustup for i688 #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged

fix: rustup for i688 #590

merged 1 commit into from
May 31, 2025

Conversation

luohoufu
Copy link
Contributor

What does this PR do

This pull request updates the .github/workflows/release.yml file to refine the setup process for building the app across different target platforms. The most important change is the conditional logic added to handle platform-specific dependencies.

Workflow improvements:

  • Updated the "Pizza engine features setup" step to include conditional logic for platform-specific dependency installation. For the i686-pc-windows-msvc target, it now adds the required Rust target using rustup. For other platforms, it runs make add-dep-pizza-engine-linux and adds the target using a nightly toolchain.

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@medcl medcl merged commit 33fa516 into main May 31, 2025
1 check passed
@medcl medcl deleted the fix_ci_build_error branch May 31, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants