Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add Knowledge Base Document Parsing Status Check #5966

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

liwenju0
Copy link
Contributor

@liwenju0 liwenju0 commented Mar 12, 2025

When creating and updating chats, add a check for the parsing status of knowledge base documents. Ensure that all documents have been parsed before allowing chat creation to improve user experience and system stability.

Main Changes:

  • Add document parsing status check logic in chat.py.
  • Implement the is_parsed_done method in knowledgebase_service.py.
  • Prevent chat creation when documents are being parsed or parsing has failed.

What problem does this PR solve?

fix this bug:#5960

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

When creating and updating chats, add a check for the parsing status of knowledge base documents. Ensure that all documents have been parsed before allowing chat creation to improve user experience and system stability.

**Main Changes:**

- Add document parsing status check logic in `chat.py`.
- Implement the `is_parsed_done` method in `knowledgebase_service.py`.
- Prevent chat creation when documents are being parsed or parsing has failed.
@KevinHuSh KevinHuSh changed the title **BUGFIX: Add Knowledge Base Document Parsing Status Check** Fix: Add Knowledge Base Document Parsing Status Check** Mar 12, 2025
@KevinHuSh KevinHuSh changed the title Fix: Add Knowledge Base Document Parsing Status Check** Fix: Add Knowledge Base Document Parsing Status Check Mar 12, 2025
@KevinHuSh KevinHuSh added the ci Continue Integration label Mar 12, 2025
@KevinHuSh KevinHuSh merged commit e3ea4b7 into infiniflow:main Mar 12, 2025
3 of 4 checks passed
jiharal pushed a commit to jiharal/ragflow that referenced this pull request Mar 13, 2025
When creating and updating chats, add a check for the parsing status of
knowledge base documents. Ensure that all documents have been parsed
before allowing chat creation to improve user experience and system
stability.

**Main Changes:**

- Add document parsing status check logic in `chat.py`.
- Implement the `is_parsed_done` method in `knowledgebase_service.py`.
- Prevent chat creation when documents are being parsed or parsing has
failed.

### What problem does this PR solve?

fix this bug:infiniflow#5960

### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)

Co-authored-by: wenju.li <wenju.li@deepctr.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continue Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants