Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error of changing embedding model #4184

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

JinHai-CN
Copy link
Contributor

@JinHai-CN JinHai-CN commented Dec 23, 2024

What problem does this PR solve?

  1. Change embedding model of knowledge base won't change the default embedding model.
  2. Retrieval test bug

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

Signed-off-by: jinhai <haijin.chn@gmail.com>
@JinHai-CN JinHai-CN added the ci Continue Integration label Dec 23, 2024
Signed-off-by: jinhai <haijin.chn@gmail.com>
@JinHai-CN JinHai-CN requested a review from KevinHuSh December 23, 2024 08:23
@KevinHuSh KevinHuSh merged commit 4abc144 into infiniflow:main Dec 23, 2024
2 checks passed
baifachuan pushed a commit to baifachuan/ragflow that referenced this pull request Dec 26, 2024
### What problem does this PR solve?

1. Change embedding model of knowledge base won't change the default
embedding model.
2. Retrieval test bug

### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)

---------

Signed-off-by: jinhai <haijin.chn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continue Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants