Complete DataSet SDK implementation #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinHuSh
reviewed
Aug 30, 2024
| return get_data_error_result( | ||
| retmsg="Delete dataset error.(Database error)") | ||
| return get_json_result(data=True) | ||
| retmsg="id is required") |
There was a problem hiding this comment.
if "id" not in req: return get_data_error_result(retmsg="id is required")
KevinHuSh
reviewed
Aug 30, 2024
api/apps/sdk/dataset.py
Outdated
|
|
||
|
|
||
| @manager.route('/list', methods=['GET']) | ||
| @token_required | ||
| def list_datasets(tenant_id): | ||
| page_number = int(request.args.get("page", 1)) | ||
| items_per_page = int(request.args.get("page_size", 1024)) | ||
| orderby = request.args.get("orderby", "create_time") | ||
| orderby = request.args.get("orderby", "create_by") |
There was a problem hiding this comment.
Suggested change
| orderby = request.args.get("orderby", "create_by") | |
| orderby = request.args.get("orderby", "create_time") |
KevinHuSh
reviewed
Aug 30, 2024
api/apps/sdk/dataset.py
Outdated
| desc = bool(request.args.get("desc", True)) | ||
| tenants = TenantService.get_joined_tenants_by_user_id(tenant_id) | ||
| kbs = KnowledgebaseService.get_by_tenant_ids( | ||
| [m["tenant_id"] for m in tenants], tenant_id, page_number, items_per_page, orderby, desc) | ||
| return get_json_result(data=kbs) | ||
| renamed_list = [] | ||
| if kbs: |
There was a problem hiding this comment.
is this 'if' nessasary?
KevinHuSh
reviewed
Aug 30, 2024
|
|
||
|
|
||
| @manager.route('/detail', methods=['GET']) | ||
| @token_required | ||
| def detail(tenant_id): | ||
| req = request.args | ||
| key_mapping = { |
There was a problem hiding this comment.
This one is good. Respect!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Complete DataSet SDK implementation
#1102
Type of change