[Bug]: thumbup is false after I give thumbup for message, which let it's difficult to determine the feedback status

[victoryshao]

Is there an existing issue for the same bug?

• I have checked the existing issues.

RAGFlow workspace code commit ID

not sure, I'm using the docker iamge

RAGFlow image version

tag:v0.16.0-slim, image-id:dc20d4239e94

Other environment information

Actual behavior

thumbup is false after I give thumbup for message, like below

{
    "role": "assistant",
    "content": "xxx",
    "created_at": 1740981333.768071,
    "id": "5a363aac-3266-4b7e-a6ed-99342944aadc",
    "thumbup": false
}

I found that issue when I trying to export the conversation and trying to find my feedback. I believe this issue is caused by the code of https://github.com/infiniflow/ragflow/blob/main/api/apps/conversation_app.py#L326.

By checking the thumbup http request, I can see that the request body dose not have the key "set" but "thumbup"

The thing is: If I give the thumbs up first and then give a bad feedback, I can determine the tagging status of the message based on whether or not there is a feedback field value in the message, but if I give the thumbs up after giving the bad feedback (with the intention of modifying the tagging status a little bit), there's no way for me to know the true tagging status of the message because the database won't even be updated

Expected behavior

thumbup should be true here.

Steps to reproduce

1. start up the ragflow server by docker-compose
2. create the dialog
3. start a new conversation and talk to the dialog
4. give thumbup
5. check the `message` column of `donversation` table in mysql

Additional information

No response

[KevinHuSh]

The function of thumb up/down is not implemented yet.

[victoryshao]

@KevinHuSh Got it!

By the way, I made some little change in https://github.com/infiniflow/ragflow/blob/main/api/apps/conversation_app.py#L326 and it's now works for me.

I just changed up_down = req.get("set") to up_down = req.get("thumbup")