Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2171 Remove Practitioner from SEARCHABLE_DELAYED_RESOURCES #172

Merged
merged 1 commit into from
May 3, 2024

Conversation

yunwwang
Copy link
Contributor

@yunwwang yunwwang commented May 1, 2024

Summary

This PR fixes GitHub Issue onc-healthit/onc-certification-g10-test-kit#510

Change Log

  • Move Practitioner from SEARCHABLE_DELAYED_RESOURCES to NON_USCDI_RESOURCE
  • Remove Specimen from NON_USCDI_RESOURCE because it is a USCDI v3 data element.
  • Update group_metadata logic so that not mandatory patient searches (the one in Specimen) are counted as no_patient_search

Testing Guidance

This can be only tested in (g)(10) test kit.

  • Add us-core-test-kit path to g10 test kit's gem file:
    • gem 'us_core_test_kit', path: '[path_to]/us-core-test-kit'
  • Run bundle install, inferno service start, inferno start
  • Start G10 test with US Core v6.1.0.
  • Verify that Practitioner test group (10.41) does not have any search tests.
  • Verify that Specimen test group (10.44) does not have any search tests

@Jammjammjamm
Copy link
Contributor

Why are there no search tests for Specimen if it's in USCDI?

@yunwwang
Copy link
Contributor Author

yunwwang commented May 2, 2024

US Core v6.1.0 Specimen Profile has one mandatory id search. Other searches are optional. Hmm. Maybe we should add _id search in? We didn't have that in g10 before. We can fix that in another ticket. This can be fixed by simply add "Specimen" to "SEARCHABLE_DELAYED_RESOURCES" array. Then the search by _id test shows up in g10. Do we want to make the change? This is a breaking change.

@Jammjammjamm
Copy link
Contributor

I don't see any specimen searches in g10. Do we have a github issue for the specimen issue?

Screenshot 2024-05-03 at 9 29 27 AM

@yunwwang yunwwang merged commit c8d433a into main May 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants