generated from inferno-framework/inferno-template
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-2371: Add granular scopes tests #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jammjammjamm
force-pushed
the
fi-2371-add-fine-grained-scopes-tests
branch
from
January 14, 2024 16:27
9845dd2
to
d4c2f8b
Compare
Jammjammjamm
force-pushed
the
fi-2371-add-fine-grained-scopes-tests
branch
from
January 14, 2024 16:29
d4c2f8b
to
e0fb8ce
Compare
Jammjammjamm
force-pushed
the
fi-2371-add-fine-grained-scopes-tests
branch
from
January 25, 2024 15:38
4096edd
to
ee91e36
Compare
yunwwang
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested during Connectathon. Looks good
Jammjammjamm
force-pushed
the
fi-2371-add-fine-grained-scopes-tests
branch
from
February 5, 2024 16:36
ee91e36
to
4b724b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds testing for granular scopes.
During the normal FHIR API tests, requests for resources with required granular scopes are tagged with their resource type and search param names, e.g.
Condition?patient&category
. The granular scope tests then load up all of the requests from the normal FHIR API tests for a particular set of search params and repeat them, verifying that the resources returned are properly filtered according to the granted scopes.To try it out:
Tasks in follow-up tickets: