Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2371: Add granular scopes tests #148

Merged
merged 25 commits into from
Feb 5, 2024

Conversation

Jammjammjamm
Copy link
Contributor

@Jammjammjamm Jammjammjamm commented Jan 12, 2024

This branch adds testing for granular scopes.

During the normal FHIR API tests, requests for resources with required granular scopes are tagged with their resource type and search param names, e.g. Condition?patient&category. The granular scope tests then load up all of the requests from the normal FHIR API tests for a particular set of search params and repeat them, verifying that the resources returned are properly filtered according to the granted scopes.

To try it out:

  • use US Core 6 or 7 & SMART App Launch 2
  • run the normal US Core FHIR API tests
  • run one of the granular scope launches & FHIR API w/Granular Scopes tests

Tasks in follow-up tickets:

  • Add read interaction tests
  • Add tests to verify that the required scopes were granted

@Jammjammjamm Jammjammjamm self-assigned this Jan 12, 2024
@Jammjammjamm Jammjammjamm force-pushed the fi-2371-add-fine-grained-scopes-tests branch from 9845dd2 to d4c2f8b Compare January 14, 2024 16:27
@Jammjammjamm Jammjammjamm force-pushed the fi-2371-add-fine-grained-scopes-tests branch from d4c2f8b to e0fb8ce Compare January 14, 2024 16:29
@Jammjammjamm Jammjammjamm force-pushed the fi-2371-add-fine-grained-scopes-tests branch from 4096edd to ee91e36 Compare January 25, 2024 15:38
@Jammjammjamm Jammjammjamm marked this pull request as ready for review January 25, 2024 15:42
Copy link
Contributor

@yunwwang yunwwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested during Connectathon. Looks good

@Jammjammjamm Jammjammjamm force-pushed the fi-2371-add-fine-grained-scopes-tests branch from ee91e36 to 4b724b4 Compare February 5, 2024 16:36
@Jammjammjamm Jammjammjamm merged commit 929de6b into main Feb 5, 2024
2 checks passed
@Jammjammjamm Jammjammjamm deleted the fi-2371-add-fine-grained-scopes-tests branch February 5, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants