Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['2.6', '2.7']
ruby-version: ['2.7', '3.2']

steps:
- uses: actions/checkout@v2
Expand All @@ -23,4 +23,4 @@ jobs:
- name: Run tests
run: bundle exec rake
- name: Rubocop
run: bundle exec rubocop
run: bundle exec rubocop
209 changes: 159 additions & 50 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,21 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2021-03-30 17:30:14 -0400 using RuboCop version 0.80.0.
# on 2023-03-13 17:58:33 UTC using RuboCop version 1.48.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyleAlignWith, Severity.
# SupportedStylesAlignWith: start_of_line, begin
Layout/BeginEndAlignment:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/model.rb'

# Offense count: 49
# Cop supports --auto-correct.
# This cop supports safe autocorrection (--autocorrect).
Layout/EmptyLineAfterGuardClause:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/definitions.rb'
Expand All @@ -23,31 +31,39 @@ Layout/EmptyLineAfterGuardClause:
- 'lib/fhir_stu3_models/fluentpath/parse.rb'

# Offense count: 1
# Cop supports --auto-correct.
# This cop supports safe autocorrection (--autocorrect).
Layout/RescueEnsureAlignment:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/model.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowForAlignment.
Layout/SpaceBeforeFirstArg:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/hashable.rb'

# Offense count: 6
# Cop supports --auto-correct.
# This cop supports unsafe autocorrection (--autocorrect-all).
Lint/NonDeterministicRequireOrder:
Exclude:
- 'lib/fhir_stu3_models.rb'

# Offense count: 2
# Cop supports --auto-correct.
# This cop supports safe autocorrection (--autocorrect).
Lint/ToJSON:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/json.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_finding.rb'

# Offense count: 38
# Offense count: 39
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
Metrics/AbcSize:
Max: 405
Max: 407

# Offense count: 7
# Configuration parameters: CountComments, ExcludedMethods.
# ExcludedMethods: refine
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
# AllowedMethods: refine
Metrics/BlockLength:
Max: 70

Expand All @@ -57,65 +73,103 @@ Metrics/BlockNesting:
Max: 5

# Offense count: 6
# Configuration parameters: CountComments.
# Configuration parameters: CountComments, CountAsOne.
Metrics/ClassLength:
Max: 345
Max: 343

# Offense count: 25
# Offense count: 33
# Configuration parameters: AllowedMethods, AllowedPatterns.
Metrics/CyclomaticComplexity:
Max: 69
Max: 77

# Offense count: 43
# Configuration parameters: CountComments, ExcludedMethods.
# Offense count: 45
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
Metrics/MethodLength:
Max: 127
Max: 125

# Offense count: 1
# Configuration parameters: CountComments.
# Offense count: 2
# Configuration parameters: CountComments, CountAsOne.
Metrics/ModuleLength:
Max: 114

# Offense count: 24
# Offense count: 30
# Configuration parameters: AllowedMethods, AllowedPatterns.
Metrics/PerceivedComplexity:
Max: 72
Max: 80

# Offense count: 5
# Configuration parameters: EnforcedStyle, AllowedPatterns.
# SupportedStyles: snake_case, camelCase
Naming/MethodName:
Exclude:
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_finding.rb'

# Offense count: 4
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
Naming/MethodParameterName:
Exclude:
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_compare.rb'

# Offense count: 2
# Cop supports --auto-correct.
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: PreferredName.
Naming/RescuedExceptionsVariableName:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/hashable.rb'

# Offense count: 33
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: separated, grouped
Style/AccessorGrouping:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/field.rb'
- 'lib/fhir_stu3_models/bootstrap/generator.rb'
- 'lib/fhir_stu3_models/bootstrap/template.rb'
- 'lib/fhir_stu3_models/fhir_ext/element_definition.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_finding.rb'

# Offense count: 1
# Configuration parameters: .
# SupportedStyles: inline, group
Style/AccessModifierDeclarations:
EnforcedStyle: inline
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: nested, compact
Style/ClassAndModuleChildren:
Exclude:
- '.simplecov'

# Offense count: 17
Style/ClassVars:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/definitions.rb'
- 'lib/fhir_stu3_models/fluentpath/parse.rb'

# Offense count: 1
Style/CombinableLoops:
Exclude:
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_compare.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: Keywords, RequireColon.
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE
Style/CommentAnnotation:
Exclude:
- 'Guardfile'

# Offense count: 6
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/CommentedKeyword:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/hashable.rb'
- 'lib/fhir_stu3_models/bootstrap/model.rb'

# Offense count: 14
# Offense count: 15
# Configuration parameters: AllowedConstants.
Style/Documentation:
Exclude:
- 'spec/**/*'
- 'test/**/*'
- '.simplecov'
- 'lib/fhir_stu3_models/bootstrap/definitions.rb'
- 'lib/fhir_stu3_models/bootstrap/field.rb'
- 'lib/fhir_stu3_models/bootstrap/generator.rb'
Expand All @@ -131,51 +185,72 @@ Style/Documentation:
- 'lib/fhir_stu3_models/fluentpath/expression.rb'
- 'lib/fhir_stu3_models/fluentpath/parse.rb'

# Offense count: 22
# Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: always, always_true, never
Style/FrozenStringLiteralComment:
Enabled: false
# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/GlobalStdStream:
Exclude:
- 'lib/fhir_stu3_models/fhir.rb'

# Offense count: 29
# Cop supports --auto-correct.
# Offense count: 28
# This cop supports safe autocorrection (--autocorrect).
Style/IfUnlessModifier:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/generator.rb'
- 'lib/fhir_stu3_models/bootstrap/hashable.rb'
- 'lib/fhir_stu3_models/bootstrap/model.rb'
- 'lib/fhir_stu3_models/bootstrap/template.rb'
- 'lib/fhir_stu3_models/bootstrap/xml.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_compare.rb'

# Offense count: 1
Style/MethodMissingSuper:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/model.rb'

# Offense count: 1
Style/MissingRespondToMissing:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/model.rb'

# Offense count: 9
# Offense count: 6
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowMethodComparison.
Style/MultipleComparison:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/definitions.rb'
- 'lib/fhir_stu3_models/bootstrap/generator.rb'
- 'lib/fhir_stu3_models/bootstrap/model.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'

# Offense count: 2
# Configuration parameters: AllowedMethods.
# AllowedMethods: respond_to_missing?
Style/OptionalBooleanParameter:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/generator.rb'
- 'lib/fhir_stu3_models/bootstrap/template.rb'

# Offense count: 1
# Cop supports --auto-correct.
# This cop supports safe autocorrection (--autocorrect).
Style/OrAssignment:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/generator.rb'

# Offense count: 3
# This cop supports safe autocorrection (--autocorrect).
Style/RedundantRegexpCharacterClass:
Exclude:
- 'lib/fhir_stu3_models/fhir.rb'

# Offense count: 3
# This cop supports safe autocorrection (--autocorrect).
Style/RedundantRegexpEscape:
Exclude:
- 'lib/fhir_stu3_models/fhir.rb'
- 'lib/fhir_stu3_models/fluentpath/parse.rb'

# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/RedundantSelfAssignment:
Exclude:
- 'lib/fhir_stu3_models/fhir_ext/element_definition.rb'

# Offense count: 16
# Cop supports --auto-correct.
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, explicit
Style/RescueStandardError:
Expand All @@ -192,19 +267,53 @@ Style/RescueStandardError:
- 'lib/fhir_stu3_models/fluentpath/parse.rb'

# Offense count: 4
# Cop supports --auto-correct.
# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
# AllowedMethods: present?, blank?, presence, try, try!
Style/SafeNavigation:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/xml.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'

# Offense count: 9
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/SlicingWithRange:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/field.rb'
- 'lib/fhir_stu3_models/bootstrap/generator.rb'
- 'lib/fhir_stu3_models/bootstrap/model.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'
- 'lib/fhir_stu3_models/fluentpath/parse.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowModifier.
Style/SoleNestedConditional:
Exclude:
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_compare.rb'

# Offense count: 5
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiterals:
Exclude:
- '.simplecov'

# Offense count: 7
# Cop supports --auto-correct.
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: forbid_for_all_comparison_operators, forbid_for_equality_operators_only, require_for_all_comparison_operators, require_for_equality_operators_only
Style/YodaCondition:
Exclude:
- 'lib/fhir_stu3_models/bootstrap/preprocess.rb'
- 'lib/fhir_stu3_models/fluentpath/parse.rb'

# Offense count: 8
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/ZeroLengthPredicate:
Exclude:
- 'lib/fhir_stu3_models/fhir.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition.rb'
- 'lib/fhir_stu3_models/fhir_ext/structure_definition_compare.rb'
- 'lib/fhir_stu3_models/fluentpath/parse.rb'
Loading