fix(a2a): Fix task cancellation race condition #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where A2A task cancellation didn't work properly. The issue was that CancelBackgroundTask() was using a stale copy of TaskPollingState from GetBackgroundTasks() instead of getting the live polling state from the task tracker. This caused: 1. Tasks to disappear from the UI task list (cleanup was called) 2. But the actual background polling goroutine continued running 3. A2A server never received the cancellation request The fix gets the live polling state directly from taskTracker.GetPollingState() which ensures the correct CancelFunc is called to stop the active goroutine. Fixes #195 Co-authored-by: Eden Reich <edenreich@users.noreply.github.com>
edenreich
commented
Oct 22, 2025
edenreich
commented
Oct 22, 2025
edenreich
commented
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where A2A task cancellation didn't work properly. The issue was that CancelBackgroundTask() was using a stale copy of TaskPollingState from GetBackgroundTasks() instead of getting the live polling state from the task tracker.
This caused:
The fix gets the live polling state directly from taskTracker.GetPollingState() which ensures the correct CancelFunc is called to stop the active goroutine.
Fixes #195
Generated with Claude Code