Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #50 Add go test to GitHub Actions #74

Merged
merged 3 commits into from
Feb 12, 2021
Merged

Fix #50 Add go test to GitHub Actions #74

merged 3 commits into from
Feb 12, 2021

Conversation

infamousjoeg
Copy link
Owner

No description provided.

@infamousjoeg infamousjoeg added the enhancement New feature or request label Feb 10, 2021
@infamousjoeg infamousjoeg self-assigned this Feb 10, 2021
@infamousjoeg
Copy link
Owner Author

Need to add PAS_USERNAME and PAS_PASSWORD to GitHub Secrets. Add environment variables for PAS_HOSTNAME and the previously mentioned two other GitHub Secrets.

Pending @AndrewCopeland adding jgarcia as a Safe Admin on the CLI test safes in PAS.

@infamousjoeg infamousjoeg linked an issue Feb 11, 2021 that may be closed by this pull request
Run go test ./... on ever PR to dev and main #50
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

AndrewCopeland
AndrewCopeland approved these changes Feb 12, 2021
View reviewed changes
Copy link
Collaborator

@AndrewCopeland AndrewCopeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewCopeland AndrewCopeland merged commit 0dc7e3c into v0.1.1-beta Feb 12, 2021
@infamousjoeg infamousjoeg deleted the fix-50-automate-gotest branch February 14, 2021 00:03
AndrewCopeland added a commit that referenced this pull request Feb 19, 2021
@AndrewCopeland
V0.1.1 beta (#81)
c5f0747 
* Fix #58 refactor api structs (#72)

* Attempt to use environment variables if found (#73)

* Updated container release ghcr.io (#75)

* Fix #50 Add go test to GitHub Actions (#74)

* Fix #77 cybr safe add user search in bug (#79)

* Fix #67 ccp retrieve account beta v0.1.1 (#78)

* Fix #68 cybr users add v0.1.1 beta (#76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewCopeland AndrewCopeland AndrewCopeland approved these changes

Assignees

@infamousjoeg infamousjoeg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run go test ./... on ever PR to dev and main
2 participants
@infamousjoeg @AndrewCopeland