Refactor Blanket::Wrapper#uri_from_parts to allow full paths#16
Merged
inf0rmer merged 3 commits intoinf0rmer:masterfrom Feb 2, 2015
Merged
Refactor Blanket::Wrapper#uri_from_parts to allow full paths#16inf0rmer merged 3 commits intoinf0rmer:masterfrom
Blanket::Wrapper#uri_from_parts to allow full paths#16inf0rmer merged 3 commits intoinf0rmer:masterfrom
Conversation
Owner
|
Hi, thanks for contributing! The code looks great, however would you mind complementing your PR with the following:
|
Closed
6c1ae2a to
1b32d2f
Compare
Contributor
Author
|
There, docs and readme ready. And I also pushed the minor version number up to 2.0.1. |
Blanket::Wrapper#uri_from_parts to be more flexibleBlanket::Wrapper#uri_from_parts to allow full paths
Owner
|
Thanks! |
inf0rmer
added a commit
that referenced
this pull request
Feb 2, 2015
Refactors `Blanket::Wrapper#uri_from_parts` to allow full paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tiny refactor allows you to send full paths to the wrapper: