Skip to content

[BF] Fix crash in switch config list if array_sum contains non-integer #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

listerr
Copy link
Contributor

@listerr listerr commented Feb 21, 2025

Fix crash in php8.3 if array_sum contains non-integers from scaleBits()

[2025-02-20 16:24:49] production.ERROR: array_sum(): Addition is not supported on type string {"userId":725,"exception":"[object] (ErrorException(code: 0): array_sum(): Addition is not supported on type string at /srv/ixpmanager/resources/views/switches/configuration.foil.php:179)

Downgraded to php8.1 for now, but while I was on 8.3, fixed this error.

In addition to the above, I have:

  • ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent.
  • ensured appropriate checks against user privilege / resources accessed
  • API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant