Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to reseller. Use more commonly displayed abbreviatedName. #802

Merged
merged 2 commits into from
Apr 24, 2022
Merged

Link to reseller. Use more commonly displayed abbreviatedName. #802

merged 2 commits into from
Apr 24, 2022

Conversation

listerr
Copy link
Contributor

@listerr listerr commented Apr 22, 2022

Longer description

Link to reseller. Use more commonly displayed abbreviatedName.

In addition to the above, I have:

  • ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent.
  • ensured appropriate checks against user privilege / resources accessed
  • API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

@barryo barryo merged commit a68c57b into inex:master Apr 24, 2022
barryo added a commit that referenced this pull request Jul 4, 2022
@listerr @barryo
Link to reseller. Use more commonly displayed abbreviatedName. (#802)
0d7d3f2 
* Link to reseller. Use more commonly displayed abbreviatedName.

* Lose whitespace in single element link

Co-authored-by: Barry O'Donovan <barry@opensolutions.ie>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@listerr @barryo