Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RS Looking Glass sort order #544

Closed
listerr opened this issue Jul 18, 2019 · 2 comments
Closed

RS Looking Glass sort order #544

listerr opened this issue Jul 18, 2019 · 2 comments
Assignees
@yannrobin
Labels
Improvement

Comments

@listerr
Copy link
Contributor

listerr commented Jul 18, 2019

SUMMARY

Not sure if this should be in IXP Manager or Looking glass project - it includes a sort option at the top for "State/PfxRcd" but this sorts lexical order rather than numerically. Other columns (asn etc.) sort correctly in numerical order.

STEPS TO REPRODUCE

Click sort option on the "State/PfxRcd" column.

image
@barryo
Copy link
Member

barryo commented Jul 18, 2019

Should be here - @yannrobin can you add invisible sorting columns for these with -1 for any non-numeric value?

@yannrobin
Copy link
Contributor

Sure I will

yannrobin added a commit that referenced this issue Jul 25, 2019
@yannrobin
[BF] - RS Looking Glass sort order - fixes #544
90630bd
@barryo barryo closed this as completed in 3adfd03 Jul 26, 2019
barryo added a commit that referenced this issue Jul 26, 2019
@barryo
Revert "[BF] - RS Looking Glass sort order - fixes #544"
b235d9e 
This reverts commit 3adfd03.
barryo added a commit that referenced this issue Jul 26, 2019
@barryo
Revert "[BF] - RS Looking Glass sort order - fixes #544"
49b241c 
This reverts commit 3adfd03.
yannrobin added a commit that referenced this issue Jul 26, 2019
@yannrobin
[BF] - RS Looking Glass sort order - fixes #544
1819723
barryo pushed a commit that referenced this issue Jul 27, 2019
@yannrobin @barryo
RS Looking Glass sort order - fixes #544 (#551)
75109da 
* [BF] - RS Looking Glass sort order - fixes #544

* [BF] - RS Looking Glass sort order - fixes #544

* [IM] Complete looking glass sorting issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yannrobin yannrobin

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@barryo @listerr @yannrobin