Skip to content

Commit

Permalink
[IM] Fully disable standard community filtering if route server ASN i…
Browse files Browse the repository at this point in the history
…s 32bit

While strictly speaking the first filter (0,peeasn) could work, the other
do will not. Better to be explicit and match the documentation and fully
disable community based filtering for route servers with a 32bit asn.

Reminder: we discourage using 32bit ASNs for route servers:

> You are strongly advised to use / request a 16-bit ASN from your RIR
> for route server use. If you do not, you will be unable to offer your
> members standard community based filtering.

Separatrely, we have a feature in development that will allow people to
set filters in the UI and which uses large BGP communities internally.
  • Loading branch information
barryo committed Apr 13, 2020
1 parent 5cb4a0f commit 4372d79
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion data/travis-ci/known-good/ci-apiv4-b2-rs1-lan1-ipv4.conf
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ function ixp_community_filter(int peerasn)
return true;

# it's unwise to conduct a 32-bit check on a 16-bit value
if peerasn > 65535 then
if routeserverasn > 65535 || peerasn > 65535 then
return true;

# Implement widely used community filtering schema.
Expand Down
2 changes: 1 addition & 1 deletion data/travis-ci/known-good/ci-apiv4-b2-rs1-lan1-ipv6.conf
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ function ixp_community_filter(int peerasn)
return true;

# it's unwise to conduct a 32-bit check on a 16-bit value
if peerasn > 65535 then
if routeserverasn > 65535 || peerasn > 65535 then
return true;

# Implement widely used community filtering schema.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ function ixp_community_filter(int peerasn)

<?php endif; ?>
# it's unwise to conduct a 32-bit check on a 16-bit value
if peerasn > 65535 then
if routeserverasn > 65535 || peerasn > 65535 then
return true;

# Implement widely used community filtering schema.
Expand Down

0 comments on commit 4372d79

Please sign in to comment.