Skip to content

Conversation

@skryukov
Copy link
Contributor

@skryukov skryukov commented Nov 1, 2024

This PR adds Algolia DocSearch API keys.

provider: 'algolia',
options: {
appId: 'BWKGTG68ZO',
apiKey: '06bc959e3f6ab7eb186cd27653408b04',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there risk to having this in the repo? i can throw (a regenerated) key in a Github Actions secret if we don't want this public.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok. These are client-side keys, so they are rendered in the html anyways, like google analytics: https://docsearch.algolia.com/docs/docsearch-v3#implementation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, i should have know 👍

@bknoles bknoles merged commit 1387f4c into inertiajs:master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants