Add support for (multiple) error bags #137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Response::withErrors(..).Fixed
ViewErrorBaginstead ofMessageBag(it works due to proxy-calls, but it's not really intended to be used that way)Remaining / newly found issues
ValidationExceptiongets thrown, error messages won't get formatted correctly due to the way the ValidationException is defined/handled by the ExceptionHandler. Here's a failing test that demonstrates the issue.There's a few solutions to this that I can tell, and neither of them aren't really pretty:
Extend the Application's ExceptionHandler, then swap it out in the container. This will allow us to intercept the ValidationException and re-format the messages.
Swap out the Validator for our own, so we can throw a custom ValidationException.
Tell the user to add a call to their Application's ExceptionHandler, so we don't have to override/extend any core-logic (less maintenance, more work for the end-user)