[WIP] Add Point codec methods: #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| bytes.length - 1 === len) { | ||
| return this.pointFromX(bytes.slice(1, 1 + len), bytes[0] === 0x03); | ||
| } | ||
| throw new Error('Unknown point format'); |
There was a problem hiding this comment.
Should this method try and check for validity of the point ?
|
Anything else you want changed here, or you want it squashed down? |
|
@dcousens |
| [ 0x04 ].concat(x, intToBE(this.getY(), len)) ; | ||
| }; | ||
|
|
||
| BasePoint.prototype.encode = function encode(compact, enc) { |
There was a problem hiding this comment.
How do we feel about switching the order of the compact and enc args around ? In context of encodeCompressed ?
|
I inlined those methods, and fixed the quoting issues, along with some other lint issues. It might pay to enable linting etc for the tests eh ( when moving to semi-standard probably a good time) ? |
|
@sublimator there is a mental cost for them (at least for me). Linting tests makes sense to me! |
|
LGTM, please squash ;) |
|
squashed |
|
Landed and released, thank you! |
|
cheers :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Point#eq
Add Point#encode
Add Point#encodeCompressed
Add Curve#decodePoint
Add overrides for Montgomery curves/points
Squash of #48