Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: remove --follow-imports=skip checks #235

Closed
wants to merge 2 commits into from

Conversation

alexfikl
Copy link
Contributor

This "fixes" the mypy failure on the CI:
https://github.com/inducer/pytools/actions/runs/9630439571/job/26561001591

As far as I can tell, that nice crash was caused by

mypy --strict --follow-imports=skip pytools/persistent_dict.py

and seems to be related to python/mypy#17396. I couldn't find any nicer workaround for it though..

cc @matthiasdiener

@inducer
Copy link
Owner

inducer commented Jun 25, 2024

Thanks for finding the mypy bug! I was puzzling over how to deal with that. I've cherry-picked one commit and done an alternate fix for the mypy issue in #237. Closing here.

@inducer inducer closed this Jun 25, 2024
@alexfikl alexfikl deleted the fix-mypy branch June 25, 2024 15:36
@inducer
Copy link
Owner

inducer commented Jun 25, 2024

Hm... TIL mypy behaves differently in CI and on my machine? Weird. The "fix" in #237 clearly isn't.

@alexfikl
Copy link
Contributor Author

alexfikl commented Jun 25, 2024

Hm... TIL mypy behaves differently in CI and on my machine? Weird. The "fix" in #237 clearly isn't.

mypy caches quite heavily.. Maybe that's why? :\ i.e. a rm -rf .mypy_cache && ./run-mypy.sh might help..

@inducer
Copy link
Owner

inducer commented Jun 25, 2024

mypy caches quite heavily.. Maybe that's why? :\ i.e. a rm -rf .mypy_cache && ./run-mypy.sh might help..

Tried that! It did not. Super odd.

@alexfikl
Copy link
Contributor Author

Tried that! It did not. Super odd.

No idea then! For what it's worth, just tried #237 locally and it fails for me like on the CI.

@alexfikl alexfikl mentioned this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants