PartitionInducedCycleError: pass through CycleError #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
reviewed
Nov 18, 2022
pytato/partition.py
Outdated
| except CycleError as err: | ||
| raise PartitionInducedCycleError(err) | ||
| # type-ignore-reason: Needs a pytools release with | ||
| # https://github.com/inducer/pytools/pull/158 to pass mypy. |
Owner
There was a problem hiding this comment.
I can do that. Remind me tomorrow.
Owner
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Thanks, I removed the ignore in 1c7969f
inducer
reviewed
Nov 18, 2022
pytato/partition.py
Outdated
| raise PartitionInducedCycleError(err) | ||
| # type-ignore-reason: Needs a pytools release with | ||
| # https://github.com/inducer/pytools/pull/158 to pass mypy. | ||
| raise PartitionInducedCycleError(err) # type: ignore[no-untyped-call] |
Owner
There was a problem hiding this comment.
Maybe unpack the cycle rather than repackaging the whole error.
matthiasdiener
force-pushed
the
pass-cycle
branch
from
ae08439 to
1363d0f
Compare
matthiasdiener
force-pushed
the
pass-cycle
branch
from
4388cda to
a56643a
Compare
Owner
|
This has conflicts now, sorry. |
matthiasdiener
force-pushed
the
pass-cycle
branch
from
246b1ac to
372b2e5
Compare
Collaborator
Author
I think they have been fixed in 372b2e5. This is ready for another review. |
inducer
reviewed
Dec 12, 2022
| except CycleError: | ||
| raise PartitionInducedCycleError | ||
| except CycleError as err: | ||
| raise PartitionInducedCycleError(err.node) |
Owner
There was a problem hiding this comment.
Based on inducer/pytools#159, this should probably be err.path.
Owner
|
Converted to draft for the time being, with a to-do list in the description. |
Owner
|
Superseded by #434 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because: