-
Notifications
You must be signed in to change notification settings - Fork 16
Implements a distributed partitioner that is lazier than find_distributed_partitions
#277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0eec71d to
adb0a65
Compare
1cf864c to
dcd1158
Compare
|
With this branch: With main: That's for CNS 2D-DG operator, written at https://github.com/illinois-ceesd/drivers_y2-isolator. |
|
Whoa, nice job! It sure sounds like the lame annotations-based approach of #275 won't be needed now. |
dcd1158 to
4b66ba3
Compare
4b66ba3 to
187fc9b
Compare
15f29f8 to
8a6e7bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I enjoyed reading this, and I still think the approach is really clever. There's a number of things flagged here, but nothing fundamental. Good to go once these are addressed!
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
d72458d to
94a381d
Compare
94a381d to
0766823
Compare
Co-authored-by: Andreas Kloeckner <inform@tiker.net>
07e21a0 to
ee304ae
Compare
The newer algorithm uses the following principle: - No node other than the ones indicated by the user must be materialized. - Be eager to schedule sends.
ee304ae to
596a8e3
Compare
|
This looks great! Thanks for working on it. |
examples/distributed_partition_sends_asap.pywhich demonstrates the output for the partitioner.Draft because: