Implements stringification for arrays #181
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaushikcfd
force-pushed
the
strify
branch
5 times, most recently
from
986e50a to
2007994
Compare
Collaborator
|
Does this supersede #179? |
Collaborator
Author
Nope, I would say adds to it, as this PR doesn't define |
inducer
reviewed
Nov 1, 2021
| kwargs["shape"] = tuple(self.rec(dim) for dim in expr.shape) | ||
| return p.CallWithKwargs("IndexLambda", | ||
| parameters=(), | ||
| kw_parameters=kwargs) |
inducer
reviewed
Nov 1, 2021
| return next(filter(pred, iterable), default) | ||
|
|
||
|
|
||
| def _get_einsum_spec(einsum: Einsum) -> str: |
Owner
There was a problem hiding this comment.
Test this against "parse_einsum" to be "post-normalization inverse".
inducer
reviewed
Nov 1, 2021
|
|
||
| # {{{ stringify mapper | ||
|
|
||
| class StringifyMapper(StringifyMapperBase): |
Owner
There was a problem hiding this comment.
Exponential complexity in string concat?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because: